Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix splice hook #12786

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix splice hook #12786

merged 1 commit into from
Jul 22, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Jul 22, 2022

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicky - it is better to use oldSplice.call in that case. But the result is the same :-)

@sebavan sebavan merged commit eabbf01 into BabylonJS:master Jul 22, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
fix splice hook

Former-commit-id: f63cfb47ab88e4a023dcb94cef7064c014e000c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants