Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always clone skinned meshes for AssetContainer.instantiateModelsToScene #12764

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Always clone skinned meshes for AssetContainer.instantiateModelsToScene #12764

merged 2 commits into from
Jul 19, 2022

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Jul 19, 2022

@bghgary bghgary requested review from sebavan and deltakosh July 19, 2022 16:51
@bghgary bghgary added the bug label Jul 19, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12764/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12764/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12764/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12764/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12764/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12764/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12764/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12764/merge#BCU1XR#0

@bghgary bghgary enabled auto-merge (squash) July 19, 2022 19:26
@bghgary bghgary disabled auto-merge July 19, 2022 19:26
@bghgary bghgary enabled auto-merge (squash) July 19, 2022 19:26
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12764/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12764/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12764/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12764/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12764/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12764/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12764/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12764/merge#BCU1XR#0

@bghgary bghgary merged commit 676889a into BabylonJS:master Jul 19, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@bghgary
Always clone skinned meshes for AssetContainer.instantiateModelsToSce…
206bac2 
…ne (#12764)

Former-commit-id: f2876b2b92725a21af741d37d49167ad34f6c99d
@bghgary bghgary deleted the instantiate-fix branch December 19, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@deltakosh deltakosh Awaiting requested review from deltakosh

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bghgary @sebavan