Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix texture caching. #12652

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Fix texture caching. #12652

merged 2 commits into from
Jun 15, 2022

Conversation

carolhmj
Copy link
Contributor

sebavan
sebavan reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do it for all cube textures, passing isCube in ???

GG for the fix by the way :-)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12652/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12652/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12652/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12652/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12652/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12652/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12652/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12652/merge#BCU1XR#0

@carolhmj
Copy link
Contributor Author

Should we do it for all cube textures, passing isCube in ???

GG for the fix by the way :-)

Thanks! I'll add to the other cube textures :D

@carolhmj carolhmj requested a review from sebavan June 15, 2022 10:32
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12652/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12652/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12652/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12652/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12652/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12652/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12652/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12652/merge#BCU1XR#0

@sebavan sebavan merged commit 76c7589 into BabylonJS:master Jun 15, 2022
@carolhmj carolhmj deleted the fix-equi-texture-caching branch August 19, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolhmj @sebavan