Camera: Added divide by zero check FreeCameraTouchInput #12649
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12649/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12649/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12649/merge#BCU1XR#0 |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12649/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12649/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12649/merge#BCU1XR#0 |
In the forums, there was an issue raised where movement wasn't working on Safari. After some investigation, it was found that the
touchMoveSensibilityproperty was being used in a denominator inside of thecheckInputsfunction. Because of this, iftouchMoveSensibilitywas zero, it'd create a divide by zero scenario that would effectively render the camera'scameraDirectionvector to be a vector of NaNs. The fix for this was to just add a check to see iftouchMoveSensibilitywas zero and handle things accordingly.Forum link: https://forum.babylonjs.com/t/keyboard-control-not-working-for-latest-universalcamera-in-desktop-safari/31314