Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registerInstancedBuffer after Mesh creation #12609

Merged
merged 9 commits into from
May 31, 2022
Merged

Fix registerInstancedBuffer after Mesh creation #12609

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1664e4c
Fix prepass view uniform
sebavan May 23, 2022
e775968
Format
sebavan May 23, 2022
e36351a
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
sebavan May 24, 2022
2c53454
PBR refractionIntensityTexture in the inspector
sebavan May 24, 2022
a1c381d
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
sebavan May 30, 2022
869f402
Fix registerInstancedBuffer after Mesh creation
sebavan May 30, 2022
e9dbaec
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
sebavan May 30, 2022
ce96852
Fix Shadows after unparenting
sebavan May 30, 2022
db10574
PR feedback
sebavan May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format
  • Loading branch information
@sebavan
sebavan committed May 23, 2022
commit e775968baa3d0db88729998b115aadb5ec10921e
8 changes: 7 additions & 1 deletion packages/dev/core/src/Materials/standardMaterial.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1745,7 +1745,13 @@ export class StandardMaterial extends PushMaterial {
}

// View
if ((scene.fogEnabled && mesh.applyFog && scene.fogMode !== Scene.FOGMODE_NONE) || this._reflectionTexture || this._refractionTexture || mesh.receiveShadows || defines.PREPASS) {
if (
(scene.fogEnabled && mesh.applyFog && scene.fogMode !== Scene.FOGMODE_NONE) ||
this._reflectionTexture ||
this._refractionTexture ||
mesh.receiveShadows ||
defines.PREPASS
) {
this.bindView(effect);
}

Expand Down