New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed Native Engine capabilities to Babylon.js, fixes morph targets on Babylon Native Android #12515

Merged

SergioRZMasson merged 7 commits into BabylonJS:master from SergioRZMasson:bugfix/native-morph-targets-android

May 16, 2022

Contributor

SergioRZMasson commented May 11, 2022 •

edited

Loading

Overview

Morph targets are currently failing on Babylon Native when running on Android since bgfx does not support Texture2D arrays for Android API BGFX_CONFIG_RENDERER_OPENGLES lower than 31 (currently set to 30). The appropriate way of handling this type of problem would be to check bgfx capabilities and handle it appropriately on the JS side by setting canUseTextureForTargets property at MorphTargetManager. This PR exposes all capabilities info provided by the Native Engine so they can be accessed by the js NativeEngine and appropriately handled by Babylon.js

Aditions

Exposed Native engine caps to javascript.
After this PR gets merged the following Babylon Native PR can be merged.
Fixes Android Morph Targets issue on Babylon Native.


          Added native engine capabilities, added texture array size capability

f7d2fae

SergioRZMasson requested review from RaananW and bghgary

May 11, 2022 15:37

SergioRZMasson changed the title ~~Added native engine capabilities, added texture array size capability~~ Exposed Native Engine capabilities to Babylon.js, fixes morph targets on Babylon Native Android

This was referenced May 11, 2022

Fix Android Morph Targets - Add Native Engine Caps BabylonJS/BabylonNative#1075

Merged

Morph targets are broken on Android. BabylonJS/BabylonNative#1049

Closed

azure-pipelines bot commented May 11, 2022

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

RaananW approved these changes

View reviewed changes

Member

RaananW left a comment

Waiting for @sebavan review as well before merging


          Fixed formating with Prettier

f8b60a7

SergioRZMasson added the bug label

azure-pipelines bot commented May 11, 2022

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.


          Fixed formating with Prettier

429c5ad

deltakosh reviewed

View reviewed changes

packages/dev/core/src/Engines/webgpuEngine.ts Outdated Show resolved Hide resolved

deltakosh reviewed

View reviewed changes

packages/dev/core/src/Engines/nullEngine.ts Outdated Show resolved Hide resolved

azure-pipelines bot commented May 11, 2022

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.


          Added correct values for nullEngine and webGPU engine

72810e7

azure-pipelines bot commented May 11, 2022

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.


          Set null engine texture2DArrayMaxLayerCount to webGL 1 value

67941c8

azure-pipelines bot commented May 11, 2022

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

azure-pipelines bot commented May 11, 2022

Snapshot stored with reference name:
refs/pull/12515/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12515/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12515/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12515/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12515/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12515/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12515/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12515/merge#BCU1XR#0

bghgary reviewed

View reviewed changes

packages/dev/core/src/Engines/Native/nativeInterfaces.ts Outdated Show resolved Hide resolved

packages/dev/core/src/Engines/nativeEngine.ts Show resolved Hide resolved


          Increased PROTOCOL_VERSION to 6

cf8aa32

azure-pipelines bot commented May 12, 2022

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines bot commented May 12, 2022

Snapshot stored with reference name:
refs/pull/12515/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12515/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12515/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12515/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12515/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12515/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12515/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12515/merge#BCU1XR#0


          Removed currently unused caps

2f37470

azure-pipelines bot commented May 13, 2022

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bghgary approved these changes

View reviewed changes

azure-pipelines bot commented May 13, 2022

Snapshot stored with reference name:
refs/pull/12515/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12515/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12515/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12515/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12515/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12515/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12515/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12515/merge#BCU1XR#0

SergioRZMasson marked this pull request as ready for review

May 16, 2022 17:10

SergioRZMasson merged commit 824cc9c into BabylonJS:master

SergioRZMasson deleted the bugfix/native-morph-targets-android branch

May 16, 2022 17:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug