Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFSerializer : Prevent empty skin to export invalid GLTF #12489

Merged
merged 2 commits into from
May 9, 2022
Merged

GLTFSerializer : Prevent empty skin to export invalid GLTF #12489

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aaa6e8
format
pandaGaume May 6, 2022
de8dda5
test also negativ
pandaGaume May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/dev/serializers/src/glTF/2.0/glTFExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2226,6 +2226,9 @@ export class _Exporter {
const promiseChain = Promise.resolve();
const skinMap: { [key: number]: number } = {};
for (const skeleton of babylonScene.skeletons) {
if (skeleton.bones.length <= 0) {
continue;
}
// create skin
const skin: ISkin = { joints: [] };
const inverseBindMatrices: Matrix[] = [];
Expand Down