Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing null for First go to frame in Animation #12465

Merged
merged 1 commit into from
May 2, 2022
Merged

Missing null for First go to frame in Animation #12465

merged 1 commit into from
May 2, 2022

Conversation

CedricGuillemet
Copy link
Contributor

Follow up https://forum.babylonjs.com/t/issue-animation-gotoframe/29493/3

_frameToSyncFromJump for was null and was not used correctly for 1st go to frame. After the 1st go to frame, it's set to null and everything is fine.

@CedricGuillemet CedricGuillemet requested review from RaananW and sebavan May 2, 2022 16:59
@CedricGuillemet CedricGuillemet marked this pull request as draft May 2, 2022 17:01
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

@CedricGuillemet CedricGuillemet marked this pull request as ready for review May 2, 2022 17:49
@RaananW RaananW merged commit 477346e into BabylonJS:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants