Fix babylon.js logic for BabylonNative Canvas polyfill #10518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfromwork
requested review from
CedricGuillemet,
tymlipari,
rgerd,
ryantrem,
bghgary and
rickfromwork
chrisfromwork
changed the title
ryantrem
reviewed
Jun 17, 2021
src/Engines/nativeEngine.ts
Outdated
| premulAlpha = false; | ||
| } | ||
|
|
||
| if (texture != null && |
There was a problem hiding this comment.
Should be if (texture !== null && or just if (texture &&
There was a problem hiding this comment.
And same for check after that.
There was a problem hiding this comment.
this should now be fixed
added 2 commits
June 17, 2021 16:38
chrisfromwork
commented
Jun 17, 2021
chrisfromwork
force-pushed
the
canvasFixes
branch
from
318e9ef to
41d44b6
Compare
|
|
||
| if (DomManagement.IsDocumentAvailable() && !!document.createElement) { |
There was a problem hiding this comment.
Can you remove the check around the text portion of _rebuildContent in HolographicButton as well?
Since it looks like Image still needs the check, we can ignore HolographicSlate for now. #Closed
There was a problem hiding this comment.
this should now be fixed
sebavan
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This review contains the following changes: