Correctly invert the swapping of colour channels in Python API 'deprocess' #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 'deprocess' method, get back the image with the original channel order by inverting the original transform, rather than reversing the tuple which is incorrect.
shelhamer
added a commit
that referenced
this pull request
May 23, 2014
Correctly invert the swapping of colour channels in Python API 'deprocess'
|
Thanks for the fix! |
| @@ -284,7 +284,8 @@ def _Net_deprocess(self, input_name, input_): | |||
| decaf_in += mean | |||
| decaf_in = decaf_in.transpose((1,2,0)) | |||
| if channel_order: | |||
| decaf_in = decaf_in[:, :, channel_order[::-1]] | |||
| channel_order_inverse = tuple([channel_order.index(i) for i in (0,1,2)]) | |||
There was a problem hiding this comment.
for i in range(decaf_in.shape[2]) to support any number of channels.
shelhamer
added a commit
that referenced
this pull request
May 23, 2014
shelhamer
added a commit
that referenced
this pull request
May 23, 2014
shelhamer
added a commit
that referenced
this pull request
May 25, 2014
fix OSX 10.9 compiler/stdlib override for latest homebrew follow-up on #443 to invert k channels (instead of 3) Correctly invert the swapping of colour channels link presentation on dropbox (was self-hosted during a dropbox issue) link to demo fix draw_net python script release v1 model defs + weights point out @niuzhiheng's work on the Windows port fix test_all path in docs link canonical bvlc site fix detection notebook link
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Correctly invert the swapping of colour channels in Python API 'deprocess'
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
fix OSX 10.9 compiler/stdlib override for latest homebrew follow-up on BVLC#443 to invert k channels (instead of 3) Correctly invert the swapping of colour channels link presentation on dropbox (was self-hosted during a dropbox issue) link to demo fix draw_net python script release v1 model defs + weights point out @niuzhiheng's work on the Windows port fix test_all path in docs link canonical bvlc site fix detection notebook link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 'deprocess' method, get back the image with the original channel order
by inverting the original transform, rather than reversing the tuple which is
incorrect.