Skip to content

Conversation

@n3011
Copy link

@n3011 n3011 commented Jan 15, 2016

Fixes unnecessary error reporting. Mean shape incompatible with input shape

@seanbell
Copy link

  1. Why is this unnecessary error reporting? The mean image is spatially dependent, so it doesn't make sense to always blindly resize it. I think a safer option to get your feature is to add a parameter to the function (default False) that allows for resizing if the shapes don't match.
  2. If your mean image a constant value (which is a reasonable input) then this will introduce a NaN since m_min = m_max.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added lines 258-265 are indented by 2 spaces too many. This is a syntax error I believe.

The old code is left there commented out.

deepali-c added a commit to ibmsoe/caffe that referenced this pull request Oct 6, 2016
deepali-c added a commit to ibmsoe/caffe that referenced this pull request Oct 12, 2016
… with input shape taken from PR BVLC#3555"

This reverts commit 1374f33.
@Noiredd
Copy link
Member

Noiredd commented Feb 26, 2018

Fixed in #5719

@Noiredd Noiredd closed this Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants