Update detect.py #1198
Closed
Update detect.py #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generator causes an error in detect_windows because it is run twice there. Better store it as a data structure instead.
|
Makes sense. @shelhamer is there a reason this was a generator in the first place? @dbbert, if we're going to use a list instead, just write a list comprehension ( |
|
@longjon If I had a reason I've forgotten it. The list comprehension seems perfectly right here. |
Replaced generator with a list comprehension
|
Replaced the generator with a list comprehension, works fine now. Thanks! |
longjon
added a commit
that referenced
this pull request
Oct 2, 2014
longjon
added a commit
that referenced
this pull request
Oct 2, 2014
|
Looks good, but please obey PEP8/Google Python style by not exceeding 80 characters per line. I went ahead and squashed these commits, amended to follow the original formatting, and merged into master and dev as 4e0868d. Thanks for the fix! |
shelhamer
added a commit
that referenced
this pull request
Oct 8, 2014
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Oct 11, 2014
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Oct 11, 2014
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generator causes an error in detect_windows because it is run twice there. Better store it as a data structure instead.