Expose &Texture to users via RenderGraphDataStore #462
Conversation
This is required to interact with some wgpu APIs (like copy from texture to buffer) that require a texture, not a view.
| base_array_layer: region.layer_start, | ||
| array_layer_count: Some(NonZeroU32::new(region.layer_end - region.layer_start).unwrap()), | ||
| ..TextureViewDescriptor::default() | ||
| }); | ||
| vacant.insert(view); | ||
| vacant.insert((view, Arc::clone(texture))); |
There was a problem hiding this comment.
I tried to make the change as unintrusive as possible, so now the active_views stores both a TextureView and an Arc<Texture> with the texture it was created from as a tuple.
| desc: &RenderPassTargets, | ||
| encoder: &'rpass mut CommandEncoder, | ||
| node_idx: usize, | ||
| pass_end_idx: usize, | ||
| resource_spans: &'rpass FastHashMap<GraphResource, ResourceSpan>, | ||
| active_views: &'rpass FastHashMap<TextureRegion, TextureView>, | ||
| active_views: &'rpass FastHashMap<TextureRegion, (TextureView, A)>, |
There was a problem hiding this comment.
The Arc<Texture> part of the tuple was unused in this function, so I added a generic parameter with no bounds just to document that the function doesn't really care about this. Hopefully that's not too weird. Let me know if you know a better approach!
| GraphSubResource::ImportedTexture(_) => { | ||
| panic!("Getting render target as a texture not supported for imported textures"); |
There was a problem hiding this comment.
I don't know if there's a good equivalent for ImportedTextures we can use here. Since the purpose of imported textures is a bit unclear to me, I decided to leave this as unsupported.
| panic!("internal rendergraph error: tried to get a {:?} as a render target", r) | ||
| panic!("internal rendergraph error: tried to get a {r:?} as a render target") |
There was a problem hiding this comment.
Clippy will soon complain about this, so I took the chance to adapt the new warnings in the files I touched.
Checklist
cargo fmthas been rancargo clippyreports no issuescargo testsucceedscargo rend3-dochas no warningscargo deny checkissues have been fixed or added to deny.tomlAdded new functionality @githubname.Related Issues
None that I know of, but there's a related discussion on Matrix: https://matrix.to/#/!telLUrJoXXaQkubDie:matrix.org/$yWhwEvotAZGH9WMT1l5lRAOLjzNefA1XIzlicG9RSos?via=matrix.org&via=t2bot.io
Description
I added a way to get a &Texture out of the render graph while inside a node. This is required to interact with some wgpu APIs (like copy from texture to buffer) which require a texture, not a view.