Fixed issue, better logging

BUTR · Sep 23, 2024 · dbd8e7e · dbd8e7e
1 parent c3669a9
commit dbd8e7e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/src/BUTR.Site.NexusMods.Server.CrashReport.v13/CrashReportV13.cs b/src/BUTR.Site.NexusMods.Server.CrashReport.v13/CrashReportV13.cs
@@ -9,6 +9,7 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Text.Json;
+using Microsoft.Extensions.Logging;
 
 namespace BUTR.Site.NexusMods.Server.CrashReport.v13;
 
@@ -35,6 +36,7 @@ private static string GetException(ExceptionModel? exception, bool inner = false
 """;
 
     public static bool TryFromJson(
+        ILogger logger,
         IUnitOfWrite unitOfWrite,
         TenantId tenant,
         CrashReportFileId fileId,
@@ -59,8 +61,9 @@ public static bool TryFromJson(
         {
             report = JsonSerializer.Deserialize<CrashReportModel>(content);
         }
-        catch
+        catch (Exception e)
         {
+            logger.LogError(e, "Failed to parse JSON crash report. FileId: {FileId}, Url: {Url}", fileId, url);
             report = null;
         }
 

diff --git a/...R.Site.NexusMods.Server.CrashReport.v14/BUTR.Site.NexusMods.Server.CrashReport.v14.csproj b/...R.Site.NexusMods.Server.CrashReport.v14/BUTR.Site.NexusMods.Server.CrashReport.v14.csproj
@@ -6,8 +6,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="BUTR.CrashReport.Models" Version="14.0.0.84" />
-    <PackageReference Include="BUTR.CrashReport.Bannerlord.Parser" Version="14.0.0.84" />
+    <PackageReference Include="BUTR.CrashReport.Models" Version="14.0.0.85" />
+    <PackageReference Include="BUTR.CrashReport.Bannerlord.Parser" Version="14.0.0.85" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/src/BUTR.Site.NexusMods.Server.CrashReport.v14/CrashReportV14.cs b/src/BUTR.Site.NexusMods.Server.CrashReport.v14/CrashReportV14.cs
@@ -10,6 +10,7 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Text.Json;
+using Microsoft.Extensions.Logging;
 
 namespace BUTR.Site.NexusMods.Server.CrashReport.v14;
 
@@ -36,6 +37,7 @@ private static string GetException(ExceptionModel? exception, bool inner = false
 """;
 
     public static bool TryFromHtml(
+        ILogger logger,
         IUnitOfWrite unitOfWrite,
         TenantId tenant,
         CrashReportFileId fileId,
@@ -52,8 +54,9 @@ public static bool TryFromHtml(
         {
             report = CrashReportParser.ParseLegacyHtml(version, content);
         }
-        catch
+        catch (Exception e)
         {
+            logger.LogError(e, "Failed to parse HTML crash report. FileId: {FileId}, Url: {Url}", fileId, url);
             report = null;
         }
 
@@ -69,6 +72,7 @@ public static bool TryFromHtml(
     }
 
     public static bool TryFromJson(
+        ILogger logger,
         IUnitOfWrite unitOfWrite,
         TenantId tenant,
         CrashReportFileId fileId,
@@ -93,8 +97,9 @@ public static bool TryFromJson(
         {
             report = JsonSerializer.Deserialize<CrashReportModel>(content);
         }
-        catch
+        catch (Exception e)
         {
+            logger.LogError(e, "Failed to parse JSON crash report. FileId: {FileId}, Url: {Url}", fileId, url);
             report = null;
         }
 

diff --git a/src/BUTR.Site.NexusMods.Server/Services/General/ICrashReportBatchedHandler.cs b/src/BUTR.Site.NexusMods.Server/Services/General/ICrashReportBatchedHandler.cs
@@ -221,6 +221,7 @@ private async Task<int> WriteCrashReportsToDatabaseAsync(CancellationToken ct)
             if (version <= 12)
             {
                 var result = CrashReportV14.TryFromHtml(
+                    _logger,
                     unitOfWrite,
                     tenant,
                     fileId,
@@ -240,6 +241,7 @@ private async Task<int> WriteCrashReportsToDatabaseAsync(CancellationToken ct)
             if (version == 13)
             {
                 var result = CrashReportV13.TryFromJson(
+                    _logger,
                     unitOfWrite,
                     tenant,
                     fileId,
@@ -259,6 +261,7 @@ private async Task<int> WriteCrashReportsToDatabaseAsync(CancellationToken ct)
             if (version == 14)
             {
                 var result = CrashReportV14.TryFromJson(
+                    _logger,
                     unitOfWrite,
                     tenant,
                     fileId,