-
Notifications
You must be signed in to change notification settings - Fork 11
Fix shared pity calculation for 千星奇遇颂愿 event pools and add dynamic height calculation #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: BTMuli <72692909+BTMuli@users.noreply.github.com>
| ); | ||
| const girlData = computed<Array<TGApp.Sqlite.GachaRecords.TableGachaB>>(() => | ||
| props.modelValue.filter((item) => item.opGachaType === "20011" || item.opGachaType === "20012"), | ||
| props.modelValue.filter((item) => item.opGachaType === "20021" || item.opGachaType === "20022"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这部分卡池类型修改不对吧 @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修正,现在使用 gachaType 字段而不是 opGachaType 来过滤卡池类型。normalData 使用 gachaType === "1000",eventData 使用 gachaType === "2000"。(commit cfbda53)
|
@copilot 顺便同步一下上游 |
Co-authored-by: BTMuli <72692909+BTMuli@users.noreply.github.com>
BTMuli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GbrDataView页面参考GroDataView进行动态高度计算&监听页面尺寸变化
Co-authored-by: BTMuli <72692909+BTMuli@users.noreply.github.com>
已实现 GbrDataView 的动态高度计算和页面尺寸变化监听,参考了 GroDataView 的实现:
(commit 331c829) |
|
该 issue 已在 v0.9.0-beta 中解决。 |
gachaType === "2000"to filter event pools instead of specific opGachaType valuesSummary
Successfully implemented shared pity calculation for event pools, synced with upstream master branch, and added dynamic height calculation with window resize handling to GbrDataView component (matching GroDataView implementation). No conflicts encountered during merge.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.