Skip to content

Update networkx requirement from <=2.6.3 to <=3.4.2 #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2024

Updates the requirements on networkx to permit the latest version.

Release notes

Sourced from networkx's releases.

NetworkX 3.4.2

We're happy to announce the release of networkx 3.4.2!

Bug Fixes

  • Fix docstrings of dispatchable functions (#7679).
  • Fix draw_networkx_nodes return type (#7685).

Documentation

  • Add disclaimer about LLM driven PRs (#7683).

Maintenance

  • Fix doc warnings from recently added docs (#7682).

Contributors

6 authors added to this release (alphabetically):

4 reviewers added to this release (alphabetically):

These lists are automatically generated, and may not be complete or may contain duplicates.

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 13, 2024

The following labels could not be found: dependencies.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (5aab7dd) to head (10989b5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2023      +/-   ##
==========================================
+ Coverage   56.10%   56.20%   +0.09%     
==========================================
  Files          73       73              
  Lines       17349    17349              
  Branches     3352     3352              
==========================================
+ Hits         9734     9751      +17     
+ Misses       6773     6756      -17     
  Partials      842      842              
Flag Coverage Δ
fast-tests 56.20% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kinow
Copy link
Member

kinow commented Mar 13, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/pip/networkx-lte-3.4.2 branch from db03a00 to 78e0ee7 Compare March 13, 2025 08:01
@kinow kinow force-pushed the dependabot/pip/networkx-lte-3.4.2 branch from 78e0ee7 to ebaf445 Compare March 13, 2025 08:16
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbeltrankyl tests passing, and at least the changelog of the last release looks OK. But I see we had a very old minimum version, 2.6.3. Do you see any risk in updating this one to 3.4.2 (to get the bug/security fixes, new features, etc.) now?

Leaving this to you have the final review 👍

@dbeltrankyl
Copy link
Collaborator

Thanks @kinow , let me finish the commit tracker and I'll revise my pending reviews

@kinow
Copy link
Member

kinow commented Apr 30, 2025

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 30, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@kinow
Copy link
Member

kinow commented Apr 30, 2025

@dependabot recreate

Updates the requirements on [networkx](https://github.com/networkx/networkx) to permit the latest version.
- [Release notes](https://github.com/networkx/networkx/releases)
- [Commits](networkx/networkx@networkx-0.23...networkx-3.4.2)

---
updated-dependencies:
- dependency-name: networkx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/networkx-lte-3.4.2 branch from ebaf445 to 10989b5 Compare April 30, 2025 12:25
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, leaving to @dbeltrankyl for the final review on this one was it touches the part of the graphs.

@kinow kinow requested a review from dbeltrankyl April 30, 2025 12:44
@kinow kinow added this to the 4.1.15 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants