-
Notifications
You must be signed in to change notification settings - Fork 4
Update networkx requirement from <=2.6.3 to <=3.4.2 #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following labels could not be found: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2023 +/- ##
==========================================
+ Coverage 56.10% 56.20% +0.09%
==========================================
Files 73 73
Lines 17349 17349
Branches 3352 3352
==========================================
+ Hits 9734 9751 +17
+ Misses 6773 6756 -17
Partials 842 842
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@dependabot rebase |
db03a00
to
78e0ee7
Compare
78e0ee7
to
ebaf445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbeltrankyl tests passing, and at least the changelog of the last release looks OK. But I see we had a very old minimum version, 2.6.3. Do you see any risk in updating this one to 3.4.2 (to get the bug/security fixes, new features, etc.) now?
Leaving this to you have the final review 👍
Thanks @kinow , let me finish the commit tracker and I'll revise my pending reviews |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
Updates the requirements on [networkx](https://github.com/networkx/networkx) to permit the latest version. - [Release notes](https://github.com/networkx/networkx/releases) - [Commits](networkx/networkx@networkx-0.23...networkx-3.4.2) --- updated-dependencies: - dependency-name: networkx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
ebaf445
to
10989b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, leaving to @dbeltrankyl for the final review on this one was it touches the part of the graphs.
Updates the requirements on networkx to permit the latest version.
Release notes
Sourced from networkx's releases.
Commits
2acf159
Designate 3.4.2 release36863b0
Add disclaimer about LLM driven PRs (#7683)fb17e15
Fix draw_networkx_nodes return type (#7685)173f6c3
Fix doc warnings from recently added docs (#7682)2f45b4d
Fix docstrings of dispatchable functions (#7679)c107d25
Bump release versionab4d375
Designate 3.4.1 releasebcffd70
Update release process16fdb10
MAINT: delay loading of backend_info to after imports (#7672)3bf29e1
Bump release versionYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)