Skip to content

Commit

Permalink
Merge rust-bitcoin#731: Stop indexing hash types
Browse files Browse the repository at this point in the history
f0100e1 Stop indexing hash types (Tobin C. Harding)

Pull request description:

  In preparation for removing `SliceIndex` from hash type impls (in `bitcoin_hashes`) lets stop indexing hash types here.

  Internal change only.

ACKs for top commit:
  jlest01:
    ACK f0100e1
  Kixunil:
    ACK f0100e1
  apoelstra:
    ACK f0100e1 successfully ran local tests

Tree-SHA512: 196d83326f8d62bb095c39a67083d3f8daca65b458abffc92ebec469a6213d03003786d046f795f8b082d8e94fc1a0f7f4d5f8c66021785fb79cbbdeed8042f7
  • Loading branch information
apoelstra committed Sep 5, 2024
2 parents 59f122d + f0100e1 commit 652cace
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/secret.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ macro_rules! impl_display_secret {

let mut engine = sha256::Hash::engine();
let tag_hash = sha256::Hash::hash(tag.as_bytes());
engine.input(&tag_hash[..]);
engine.input(&tag_hash[..]);
engine.input(&tag_hash.as_ref());
engine.input(&tag_hash.as_ref());
engine.input(&self.secret_bytes());
let hash = sha256::Hash::from_engine(engine);

Expand Down

0 comments on commit 652cace

Please sign in to comment.