web (BUDA): input files are not sticky or executable #6690
Merged
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: fix bug the prevented editing a BUDA variant
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the BUDA (BOINC Universal Docker Application) job submission system. The main purpose is to correct how input files are treated in job templates and fix a bug that prevented editing existing BUDA variants.
Key changes:
- Fixed input file templates to remove incorrect
stickyandexecutableflags since input files are data files, not executables - Added logic to preserve CPU type when editing an existing BUDA variant
- Enhanced job instance display with additional columns (sent time, received time, priority)
- Updated UI text and removed obsolete layout constraints
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| html/user/buda.php | Removes sticky/executable flags from input file templates (line 231) and fixes variant editing by extracting and preserving CPU type from variant name (lines 187-189) |
| html/user/submit.php | Removes text_start/text_end wrapper (lines 828, 944) and adds three new columns to job instance table: Sent, Received, Priority (lines 847-849, 858-861) |
| html/inc/bootstrap.inc | Updates menu label from "Manage apps" to "Manage batches and apps" for better clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AenBleidd
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: fix bug the prevented editing a BUDA variant