-
Notifications
You must be signed in to change notification settings - Fork 501
Add AnnounceUpgrade test to the module boinccas module tests. #6635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AenBleidd
wants to merge
24
commits into
master
Choose a base branch
from
vko_boinccas_refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1e3dd6c
Add AnnounceUpgrade test to the module boinccas module tests.
AenBleidd 1e076d3
Fix issues
AenBleidd e2310b7
Add debug logic
AenBleidd b9e2f71
Fix unit tests
AenBleidd 7b48362
debug
AenBleidd 92cf7e4
fix
AenBleidd b7049ff
Fix test
AenBleidd 965c514
Revert debug changes
AenBleidd a6bda7b
Fix test
AenBleidd 803e30f
Test fix?
AenBleidd 52de944
Try to fix the test
AenBleidd c9d86b5
Fix tests
AenBleidd 0d999e1
Fix test split
AenBleidd c40aee4
Refactoring CAAnnounceUpgrade class
AenBleidd 37b4539
Reenable test
AenBleidd b5a5c4b
Fix tests
AenBleidd b38f287
Optimize tests
AenBleidd 7e0f95f
Add CACleanupOldBinaries test
AenBleidd d78cd1c
Refactor CACleanupOldBinaries class
AenBleidd c3c4fe6
Small refactoring, add tinyxml2 library to the vcpkg list for Windows…
AenBleidd 3a5dfa0
Add CACreateAcctMgrLoginFile tests
AenBleidd 9ccd981
Refactor CACreateAcctMgrLoginFile class
AenBleidd 0bb6a83
Enable CreateAcctMgrLoginFile tests
AenBleidd 6fe7193
Add empty CACreateBOINCAccounts test class
AenBleidd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,8 @@ | |
| { | ||
| "name": "libzip", | ||
| "default-features": false | ||
| } | ||
| }, | ||
| "wil", | ||
| "tinyxml2" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,84 +1,32 @@ | ||
| // Berkeley Open Infrastructure for Network Computing | ||
| // http://boinc.berkeley.edu | ||
| // Copyright (C) 2005 University of California | ||
| // This file is part of BOINC. | ||
| // https://boinc.berkeley.edu | ||
| // Copyright (C) 2025 University of California | ||
| // | ||
| // This is free software; you can redistribute it and/or | ||
| // modify it under the terms of the GNU Lesser General Public | ||
| // License as published by the Free Software Foundation; | ||
| // either version 2.1 of the License, or (at your option) any later version. | ||
| // BOINC is free software; you can redistribute it and/or modify it | ||
| // under the terms of the GNU Lesser General Public License | ||
| // as published by the Free Software Foundation, | ||
| // either version 3 of the License, or (at your option) any later version. | ||
| // | ||
| // This software is distributed in the hope that it will be useful, | ||
| // BOINC is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. | ||
| // See the GNU Lesser General Public License for more details. | ||
| // | ||
| // To view the GNU Lesser General Public License visit | ||
| // http://www.gnu.org/copyleft/lesser.html | ||
| // or write to the Free Software Foundation, Inc., | ||
| // 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA | ||
| // | ||
| // You should have received a copy of the GNU Lesser General Public License | ||
| // along with BOINC. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| #include "stdafx.h" | ||
| #include "boinccas.h" | ||
| #include "CAAnnounceUpgrade.h" | ||
|
|
||
| #define CUSTOMACTION_NAME _T("CAAnnounceUpgrade") | ||
| #define CUSTOMACTION_PROGRESSTITLE _T("Announce the new BOINC version to all components.") | ||
|
|
||
|
|
||
| ///////////////////////////////////////////////////////////////////// | ||
| // | ||
| // Function: | ||
| // | ||
| // Description: | ||
| // | ||
| ///////////////////////////////////////////////////////////////////// | ||
| CAAnnounceUpgrade::CAAnnounceUpgrade(MSIHANDLE hMSIHandle) : | ||
| BOINCCABase(hMSIHandle, CUSTOMACTION_NAME, CUSTOMACTION_PROGRESSTITLE) | ||
| {} | ||
|
|
||
|
|
||
| ///////////////////////////////////////////////////////////////////// | ||
| // | ||
| // Function: | ||
| // | ||
| // Description: | ||
| // | ||
| ///////////////////////////////////////////////////////////////////// | ||
| CAAnnounceUpgrade::~CAAnnounceUpgrade() | ||
| { | ||
| BOINCCABase::~BOINCCABase(); | ||
| } | ||
| BOINCCABase(hMSIHandle, _T("CAAnnounceUpgrade"), | ||
| _T("Announce the new BOINC version to all components.")) {} | ||
|
|
||
|
|
||
| ///////////////////////////////////////////////////////////////////// | ||
| // | ||
| // Function: | ||
| // | ||
| // Description: | ||
| // | ||
| ///////////////////////////////////////////////////////////////////// | ||
| UINT CAAnnounceUpgrade::OnExecution() | ||
| { | ||
| UINT CAAnnounceUpgrade::OnExecution() { | ||
| return SetUpgradeParameters(); | ||
| } | ||
|
|
||
|
|
||
| ///////////////////////////////////////////////////////////////////// | ||
| // | ||
| // Function: AnnounceUpgrade | ||
| // | ||
| // Description: | ||
| // | ||
| ///////////////////////////////////////////////////////////////////// | ||
| UINT __stdcall AnnounceUpgrade(MSIHANDLE hInstall) | ||
| { | ||
| UINT uiReturnValue = 0; | ||
|
|
||
| CAAnnounceUpgrade* pCA = new CAAnnounceUpgrade(hInstall); | ||
| uiReturnValue = pCA->Execute(); | ||
| delete pCA; | ||
|
|
||
| return uiReturnValue; | ||
| UINT __stdcall AnnounceUpgrade(MSIHANDLE hInstall) { | ||
| return CAAnnounceUpgrade(hInstall).Execute(); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,25 @@ | ||
| // Berkeley Open Infrastructure for Network Computing | ||
| // http://boinc.berkeley.edu | ||
| // Copyright (C) 2005 University of California | ||
| // This file is part of BOINC. | ||
| // https://boinc.berkeley.edu | ||
| // Copyright (C) 2025 University of California | ||
| // | ||
| // This is free software; you can redistribute it and/or | ||
| // modify it under the terms of the GNU Lesser General Public | ||
| // License as published by the Free Software Foundation; | ||
| // either version 2.1 of the License, or (at your option) any later version. | ||
| // BOINC is free software; you can redistribute it and/or modify it | ||
| // under the terms of the GNU Lesser General Public License | ||
| // as published by the Free Software Foundation, | ||
| // either version 3 of the License, or (at your option) any later version. | ||
| // | ||
| // This software is distributed in the hope that it will be useful, | ||
| // BOINC is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. | ||
| // See the GNU Lesser General Public License for more details. | ||
| // | ||
| // To view the GNU Lesser General Public License visit | ||
| // http://www.gnu.org/copyleft/lesser.html | ||
| // or write to the Free Software Foundation, Inc., | ||
| // 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA | ||
| // | ||
|
|
||
| #ifndef _CAANNOUNCEUPGRADE_H_ | ||
| #define _CAANNOUNCEUPGRADE_H_ | ||
| // You should have received a copy of the GNU Lesser General Public License | ||
| // along with BOINC. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| #pragma once | ||
|
|
||
| class CAAnnounceUpgrade : public BOINCCABase | ||
| { | ||
| public: | ||
|
|
||
| CAAnnounceUpgrade(MSIHANDLE hMSIHandle); | ||
| ~CAAnnounceUpgrade(); | ||
| virtual UINT OnExecution(); | ||
| UINT OnExecution() override final; | ||
| }; | ||
|
|
||
|
|
||
| #endif | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,25 @@ | ||
| // Berkeley Open Infrastructure for Network Computing | ||
| // http://boinc.berkeley.edu | ||
| // Copyright (C) 2005 University of California | ||
| // This file is part of BOINC. | ||
| // https://boinc.berkeley.edu | ||
| // Copyright (C) 2025 University of California | ||
| // | ||
| // This is free software; you can redistribute it and/or | ||
| // modify it under the terms of the GNU Lesser General Public | ||
| // License as published by the Free Software Foundation; | ||
| // either version 2.1 of the License, or (at your option) any later version. | ||
| // BOINC is free software; you can redistribute it and/or modify it | ||
| // under the terms of the GNU Lesser General Public License | ||
| // as published by the Free Software Foundation, | ||
| // either version 3 of the License, or (at your option) any later version. | ||
| // | ||
| // This software is distributed in the hope that it will be useful, | ||
| // BOINC is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. | ||
| // See the GNU Lesser General Public License for more details. | ||
| // | ||
| // To view the GNU Lesser General Public License visit | ||
| // http://www.gnu.org/copyleft/lesser.html | ||
| // or write to the Free Software Foundation, Inc., | ||
| // 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA | ||
| // | ||
|
|
||
| #ifndef _CACLEANUPOLDBINARIES_H_ | ||
| #define _CACLEANUPOLDBINARIES_H_ | ||
| // You should have received a copy of the GNU Lesser General Public License | ||
| // along with BOINC. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| #pragma once | ||
|
|
||
| class CACleanupOldBinaries : public BOINCCABase | ||
| { | ||
| public: | ||
|
|
||
| CACleanupOldBinaries(MSIHANDLE hMSIHandle); | ||
| ~CACleanupOldBinaries(); | ||
| virtual UINT OnExecution(); | ||
|
|
||
| UINT OnExecution() override final; | ||
| }; | ||
|
|
||
|
|
||
| #endif | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using both
overrideandfinalis redundant for documentation purposes. While technically correct,finalimpliesoverride, so using both is unnecessary. Consider using onlyfinalor keeping justoverrideif the method might be overridden in derived classes (though that seems unlikely here).