Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager: Fix branded link in About Dialog #2596

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

CharlieFenton
Copy link
Contributor

@CharlieFenton CharlieFenton commented Jul 11, 2018

Manager: in the About dialog "For more information, visit" hyperlink, set the value of the link to the same string as the text displayed for the link when using a branded skin.

NOTE: Despite the "mac" in the name of this branch, this fix is needed for all platforms.

… set the value of the link to the same string as the text displayed for the link when using a branded skin.
@CharlieFenton
Copy link
Contributor Author

@armstrdj Note that this fixes an omission from your PR #2576.

@JuhaSointusalo JuhaSointusalo merged commit 51bf79a into master Jul 11, 2018
@CharlieFenton CharlieFenton deleted the mac_fix_about_dialog_branded_url branch July 12, 2018 10:22
@AenBleidd AenBleidd added this to the Client Release 7.14 milestone Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants