[WIP] Distribution Arguments: snake_case & Default to Twiss? #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify usage & pick-up in dashboard. Straight forwarding of mean and dispersion parameters.
ax3l
added
changes input scripts / defaults
ax3l
commented
Aug 15, 2025
Comment on lines
+70
to
+71
| //AMREX_ALWAYS_ASSERT_WITH_MESSAGE(nslice > 0, | ||
| // pp_element.getPrefix() + ".nslice must be > 0."); |
There was a problem hiding this comment.
This change should not be included
- use consistent spelling of argument names - spell out abbrevations
ax3l
force-pushed
the
topic-rename-distr-args-default
branch
from
532593e to
24a974e
Compare
ax3l
commented
Aug 21, 2025
| * @param meanx,meany,meant offsets of the mean (centroid) positions from those of the reference particle | ||
| * @param meanpx,meanpy,meanpt offsets of the mean (centroid) momenta from those of the reference particle | ||
| * @param dispx,disppx,dispy,disppy dispersion and its derivative in horizontal and vertical directions | ||
| * @param lambda_x,lambda_y,lambda_t phase space axis intercepts (position); |
There was a problem hiding this comment.
Yay, this worked well with Cursor AI: I changed one distribution and told it to do the same change in the other 7 distributions 🎉
ax3l
commented
Aug 21, 2025
| py::arg("meanPx")=0.0, py::arg("meanPy")=0.0, py::arg("meanPt")=0.0, | ||
| py::arg("dispX")=0.0, py::arg("dispPx")=0.0, | ||
| py::arg("dispY")=0.0, py::arg("dispPy")=0.0, | ||
| py::arg("lambda_x"), py::arg("lambda_y"), py::arg("lambda_t"), |
There was a problem hiding this comment.
Could keep this file unchanged to avoid user breakage.
ax3l
commented
Aug 21, 2025
| alpha_x=1.3385830279518021, | ||
| alpha_y=-1.3479109197361046, | ||
| alpha_t=92.624347459169869, | ||
| dispX=-0.26669723385388505, |
There was a problem hiding this comment.
Small break, just introduced in #1099
Suggested change
| dispX=-0.26669723385388505, | |
| dispersion_x=-0.26669723385388505, |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing a few breaking changes for distributions for clarity, ease of use and potential change in defaults
Checklist
snake_case: use consistent spelling of argument names, spell out abbreviations