Skip to content

Conversation

@EZoni
Copy link
Member

@EZoni EZoni commented Jan 14, 2026

Overview

Merge the separate functions

  • update_on_change_experiment
  • update_on_change_model
  • update_on_change_others

into a single function reset, which decides what to reset after inspecting state.modified_keys.

Notes

@EZoni EZoni added dashboard Changes related to the dashboard cleaning Changes related to code cleaning labels Jan 14, 2026
@EZoni EZoni requested a review from RemiLehe January 20, 2026 23:22
Copilot AI review requested due to automatic review settings February 3, 2026 01:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors state change handling by consolidating three separate callback functions into a single unified handler. The change is part of preparatory work extracted from PR #356, which adds a control to select the type of inputs displayed in the dashboard.

Changes:

  • Merged three state change handlers (update_on_change_experiment, update_on_change_model, update_on_change_others) into a single reset function
  • The new function uses conditional branching to determine appropriate reset actions based on which state variable changed
  • All original functionality is preserved with identical reset behavior for each state variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EZoni EZoni force-pushed the cleanup_state_reactor branch from 09e7a85 to 564f81a Compare February 9, 2026 19:33
@EZoni
Copy link
Member Author

EZoni commented Feb 9, 2026

@RemiLehe

I think this PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleaning Changes related to code cleaning dashboard Changes related to the dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants