Add tmp_disk option/functionality to allow use of remote src_disk in Croppa 7. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update config docs to explain additional purpose of tmp_disk.
Describe purpose of tmp_disk.
Update README to reflect need for tmp_disk when using remote src_disk.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged @miking7's PR #210 with latest updates to use a
tmp_diskto allow remotesrc_diskto work with Intervention 3, which does not support remote files. I also updated some comments and the README to reflect thetmp_diskconfig option.This resolves issue #223.
I'm not familiar enough with mocking to know how to mock a AwsS3V3Adapter or other remote disk, so no test is provided.