New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quality url parameter causing a type error #221

Merged

sdebacker merged 1 commit into BKWLD:master from toyi:master

Jun 10, 2024

Contributor

toyi commented Jun 10, 2024

This is a very tiny PR that fixes the following error when using "-quality(xx)" in the url (since this commit from intervention/image).

Intervention\Image\Encoders\JpegEncoder::__construct(): Argument #1 ($quality) must be of type int, 
string given, called in /var/www/html/vendor/intervention/image/src/Format.php on line 129

By typing the property to int, it ensures any string will be casted to an int ("90" becomes 90 and so on...).

I don't think it needs it's own test (at least not for this specific change), but feel free to ask if you think a dedicated test is necessary.


          fix: quality query parameter causing a type error with intervention/i…

e77bea2

…mage 3

sdebacker merged commit 18c9489 into BKWLD:master

Collaborator

sdebacker commented Jun 10, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet