Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 硕博模板中cover/hideCoverInPeerReview应仍默认为 false #549

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

YDX-2147483647
Copy link
Collaborator

@YDX-2147483647 YDX-2147483647 commented Aug 28, 2024

重新实现了 #533286fa70。当时只验证了本科模板,没想到由于 LaTeX 的奇葩机制,误改了硕博模板。

Fixes #548

测试结果

\documentclass[type = …]{bithesis} \BITSetup{…} \l_@@_cover_hide_cover_in_peer_review_bool
master false(此PR前是true,之前发布版是false)
master cover/hideCoverInPeerReview = false false
master cover/hideCoverInPeerReview = true false → true
bachelor true(此PR前是true,之前发布版是false)
bachelor cover/hideCoverInPeerReview = false true → false
bachelor cover/hideCoverInPeerReview = true true
% !TeX program = xelatex
% !BIB program = biber

\documentclass[type=bachelor,twoside=false]{bithesis}

\ExplSyntaxOn
\message{DEBUG:~before~BITSetup}
\bool_log:N \l__bithesis_cover_hide_cover_in_peer_review_bool
\ExplSyntaxOff

% \BITSetup{cover/hideCoverInPeerReview = false}

\ExplSyntaxOn
\message{DEBUG:~after~BITSetup}
\bool_log:N \l__bithesis_cover_hide_cover_in_peer_review_bool
\ExplSyntaxOff


\begin{document}

\MakeCover
\MakePaperBack
\MakeTitle
\MakeOriginality

\frontmatter
\input{./chapters/abstract.tex}

\end{document}

@YDX-2147483647 YDX-2147483647 marked this pull request as ready for review August 28, 2024 14:26
@fky2015
Copy link
Contributor

fky2015 commented Aug 29, 2024

是这样的,变量的初始化是分阶段的。所以很多代码我都放在了 \ctex_at_end_preamble:n 里面。

@fky2015 fky2015 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into BITNP:main with commit c845fef Aug 29, 2024
3 checks passed
@YDX-2147483647 YDX-2147483647 deleted the default branch October 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 硕博模板的cover/hideCoverInPeerReview未能正确自动设置
2 participants