Open
Conversation
Create wallet controller that will be taking care of talking to the wallets. Currently implemented methods are: Deposit: called by a wallet server when it detects a new incoming transaction Withdraw: called by user to transfer funds CreateCornaddy: generates a new cornaddress
JasonSowers
reviewed
Nov 27, 2019
| /// <summary> | ||
| /// Lists all implemented wallet methods on the high level api as constants for Attribute access | ||
| /// </summary> | ||
| public enum ImplementedWalletMethods |
Contributor
There was a problem hiding this comment.
maybe we should go ahead and add all methods to this just so we have them for the future, maybe not
| /// <summary> | ||
| /// Wallet client interface used to communicate with the wallet implementation | ||
| /// </summary> | ||
| public interface IWalletClient |
Contributor
There was a problem hiding this comment.
Why does this need an interface?
| /// Creates wallet error object with HTTP_ERROR flag indicating that the error was in the request | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| private WalletError CreateHttpErrorResponse(HttpResponseMessage message) |
Contributor
There was a problem hiding this comment.
would stack trace help here?
| /// If call was succesfull (IsError is false), m_Content will be of type T, otherwise m_Content will be of type WalletError | ||
| /// </summary> | ||
| /// <typeparam name="T">Succesfull response datatype</typeparam> | ||
| public class ParsedWalletResponse<T> |
Contributor
There was a problem hiding this comment.
One of the wallet responses should just be "walletresponse"
| /// Deserialized Transaction info response returned by the gettransaction call | ||
| /// </summary> | ||
| [Serializable] | ||
| public class TransactionInfo |
Contributor
There was a problem hiding this comment.
I think we can call this blockchainTx
| /// <summary> | ||
| /// Deserialized error object returned by the wallet | ||
| /// </summary> | ||
| public class WalletError |
Contributor
There was a problem hiding this comment.
I think this project needs and !Error or !exception interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create wallet controller that will be taking care of talking to the wallets.
Currently implemented methods are:
Deposit: called by a wallet server when it detects a new incoming transaction
Withdraw: called by user to transfer funds
CreateCornaddy: generates a new cornaddress