Skip to content

Cleanup leftover code #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Cleanup leftover code #50

wants to merge 1 commit into from

Conversation

mschilli87
Copy link
Collaborator

Remove assembly2organism which was defined in circus.R but not used anywhere else.

When it was introduced in 82b261e it used be used in annotate.R, but that is no longer the case.

@mschilli87
Copy link
Collaborator Author

see #51 (comment) regarding the CI failures

Remove assembly2organism which was defined in circus.R but not used anywhere
else. When it was introduced in 82b261e it used be used in annotate.R, but
that is no longer the case.
@mschilli87
Copy link
Collaborator Author

mschilli87 commented Sep 28, 2018

rebased on latest dev hoping for CI not failing anymore now that f530534 is in.

@codecov-io
Copy link

codecov-io commented Sep 28, 2018

Codecov Report

Merging #50 into dev will increase coverage by 0.31%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #50      +/-   ##
==========================================
+ Coverage   58.55%   58.87%   +0.31%     
==========================================
  Files          10       10              
  Lines         736      727       -9     
==========================================
- Hits          431      428       -3     
+ Misses        305      299       -6
Impacted Files Coverage Δ
R/circus.R 0% <0%> (ø) ⬆️
R/annotate.R 79.39% <0%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f530534...c1b1da2. Read the comment docs.

@mschilli87
Copy link
Collaborator Author

Yeah! @retaj: This is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants