Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the isfinite macro when available. #7

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tjni
Copy link

@tjni tjni commented Aug 7, 2022

This is needed on M1 Macs, because its C library in libSystem no longer
includes the finite function in math.h.

Increases the minimum version of CMake so that CHECK_SYMBOL_EXISTS is
available.

This is needed on M1 Macs, because its C library in libSystem no longer
includes the finite function in math.h.

Increases the minimum version of CMake so that CHECK_SYMBOL_EXISTS is
available.
@vfonov
Copy link
Member

vfonov commented Aug 8, 2022

#include "config.h" in templates/EBTKS/SimpleArray.h will collide with other projects.

@tjni
Copy link
Author

tjni commented Aug 8, 2022

Thank you for your fast reply. So that you understand my background, I only have moderate experience with C/C++, and I am not familiar with the sorts of conflicts that can occur here. Would you be able to give me some suggestions that I can use as a starting point toward fixing this properly?

The main problem itself is that it seems finite does not exist in libc (found in libSystem.dylib) on M1 Macs.

@vfonov
Copy link
Member

vfonov commented Aug 8, 2022

so, the EBTKS is used by https://github.com/BIC-MNI/N3 , https://github.com/BIC-MNI/inormalize and https://github.com/BIC-MNI/classify , all part of https://github.com/BIC-MNI/minc-toolkit-v2 . The change will need to be done to all of them to make sure that existence of isfinite is properly done. Also, all of them use their own config.h .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants