Updating requirements to point to public cached-property #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusjusjus
approved these changes
Sep 24, 2019
Collaborator
jusjusjus
left a comment
jusjusjus
left a comment
There was a problem hiding this comment.
Sounds good. Again, we'll change it again once we have cached-property on pypi.
ViridianForge
pushed a commit
that referenced
this pull request
Oct 24, 2019
This commit addresses Issue #1. Change summary: * Added classes `mffpy.xml_files.*` to read .xml files. * Added class `mffpy.raw_bin_files.RawBinFile` to read .bin file. * Added class `mffpy.Reader` as the main interface for MFF. * Removed all old MNE files. Specific description: * `mffpy.xml_files.Epoch`. Contains time/duration information and block indices. The block indices are now used to access the data, whereas the time information is, informational with regards to a discontinuous .mff file. It's derived from a `collections.namedtuple("_Epoch","beginTime,endTime,firstBlock,lastBlock")`. * `mffpy.raw_bin_files.RawBinFile`. Reads `filename.mff/signal1.bin` files. In a static sweep, all header information is extracted. When accessing data, the file pointer of data blocks are computed and specifically read. * `mffpy.Reader`. Method `get_physical_samples(t0=None,dt=None) reads data from `t0` until `t0+dt`. Property `epochs` exposes `xml_files.Epochs.epochs`. Method `get_physical_samples_from_epoch` is added that receives an instance of `xml_files.Epoch` and returns all data in it. Optional arguments `t0`, `dt`, and `channels` can be provided. As opposed to `get_physical_samples`, `t0` is relative to `Epoch.t0`.
ViridianForge
pushed a commit
that referenced
this pull request
Oct 24, 2019
Updating requirements to point to public cached-property
ViridianForge
pushed a commit
that referenced
this pull request
Oct 24, 2019
This commit addresses Issue #1. Change summary: * Added classes `mffpy.xml_files.*` to read .xml files. * Added class `mffpy.raw_bin_files.RawBinFile` to read .bin file. * Added class `mffpy.Reader` as the main interface for MFF. * Removed all old MNE files. Specific description: * `mffpy.xml_files.Epoch`. Contains time/duration information and block indices. The block indices are now used to access the data, whereas the time information is, informational with regards to a discontinuous .mff file. It's derived from a `collections.namedtuple("_Epoch","beginTime,endTime,firstBlock,lastBlock")`. * `mffpy.raw_bin_files.RawBinFile`. Reads `filename.mff/signal1.bin` files. In a static sweep, all header information is extracted. When accessing data, the file pointer of data blocks are computed and specifically read. * `mffpy.Reader`. Method `get_physical_samples(t0=None,dt=None) reads data from `t0` until `t0+dt`. Property `epochs` exposes `xml_files.Epochs.epochs`. Method `get_physical_samples_from_epoch` is added that receives an instance of `xml_files.Epoch` and returns all data in it. Optional arguments `t0`, `dt`, and `channels` can be provided. As opposed to `get_physical_samples`, `t0` is relative to `Epoch.t0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the cached property referred to in Requirements.txt to be the Apached Licensed version available from BEL's public repository