Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate inside corners for glass/grating frames #558

Closed
LautaroL20 opened this issue May 8, 2016 · 7 comments
Closed

Generate inside corners for glass/grating frames #558

LautaroL20 opened this issue May 8, 2016 · 7 comments
Labels
Bug Something isn't working correctly Done in next release This has been addressed in the next release Enhancement Improvement or tweak to the mod

Comments

@LautaroL20
Copy link
Member

If this is something hard to do, close this. Here is a screenshot of what i mean:

20160508090128_1
@Konclan
Copy link
Collaborator

Konclan commented May 9, 2016

This seems like a bug actually

@TeamSpen210 TeamSpen210 added Bug Something isn't working correctly Enhancement Improvement or tweak to the mod labels May 9, 2016
@TeamSpen210
Copy link
Member

It's rather difficult to fix unfortunately, which might be why Valve didn't fix it. There are instances for it though.

@LautaroL20 LautaroL20 changed the title [Suggestion] Make Grating to use corner unions when they collision with other grates placements [Suggestion] Make Grating to use corner unions when they intersects with other grates placements Aug 11, 2016
@vrad-exe
Copy link
Member

vrad-exe commented Aug 9, 2019

Has this been fixed? Pretty sure I saw these appearing properly in a BEE2 map recently.

@LautaroL20
Copy link
Member Author

Do you have the link to that BEE2 map? I would like to check it myself once i finish building my new PC and then replicate it in the puzzlemaker.

@vrad-exe
Copy link
Member

vrad-exe commented Aug 9, 2019

I don't remember what map it was.

@TeamSpen210
Copy link
Member

I haven't fixed this, no.

@vrad-exe vrad-exe changed the title [Suggestion] Make Grating to use corner unions when they intersects with other grates placements Use compiler to properly generate inside corners for glass/grating frames Nov 27, 2019
@vrad-exe vrad-exe changed the title Use compiler to properly generate inside corners for glass/grating frames Generate inside corners for glass/grating frames Oct 1, 2021
TeamSpen210 added a commit to BEEmod/BEE2.4 that referenced this issue Oct 16, 2022
@TeamSpen210
Implement BEEmod/BEE2-items#558: Glass/Grating convex corners
6fe1ed4
@TeamSpen210 TeamSpen210 added the Done in next release This has been addressed in the next release label Oct 16, 2022
@LautaroL20
Copy link
Member Author

Luke18033 Said: Has this been fixed?

Yes, now it is. I thought this would be very complex to solve, but it was finally possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working correctly Done in next release This has been addressed in the next release Enhancement Improvement or tweak to the mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TeamSpen210 @LautaroL20 @Konclan @vrad-exe