Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xy box fix #706

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Xy box fix #706

merged 2 commits into from
Mar 24, 2021

Conversation

christinawlindberg
Copy link
Contributor

Fixed xy vs ra/dec priority ordering for checking whether a source density tile is within the boundary area or not. This is a short-term fix for Issue #704. Long term we will need to either figure out if shapely allows diagonal boxes or to just phase out xy functionality completely (although I'm personally not in favor of this plan)

@codecov-io
Copy link

Codecov Report

Merging #706 (2e745cd) into master (c07b3ad) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #706   +/-   ##
=======================================
  Coverage   43.83%   43.83%           
=======================================
  Files         100      100           
  Lines        9730     9730           
=======================================
  Hits         4265     4265           
  Misses       5465     5465           
Impacted Files Coverage Δ
beast/observationmodel/ast/make_ast_xy_list.py 5.04% <0.00%> (ø)
beast/plotting/plot_ast_diagnostics.py 9.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07b3ad...2e745cd. Read the comment docs.

Copy link
Member

@cmurray-astro cmurray-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! definitely open an issue re keeping the xy region capability around long term

@karllark karllark merged commit 8ae76b1 into BEAST-Fitting:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants