Added comments to metal_small settings file #24
Conversation
There was a problem hiding this comment.
Can you move all the AST parameters to the end of the settings file? There are a lot of them and the physics model needs to be defined before the AST inputs can be generated. Always have felt that having the AST inputs before the physics model details is a bit confusing. And this PR is a chance to "fix" this. If you agree of course.
|
done! I also moved the observational model parameters... lmk what you think. |
metal_small/beast_settings.txt
Outdated
| #---------------------------------- | ||
| # Source Density Binning Parameters | ||
| #---------------------------------- |
There was a problem hiding this comment.
I think this section should be moved to right before the AST parameters. Just thinking of the flow and this is related to the AST and observation model parameters. Not needed for the physical model.
This would also support other uses of the BEAST - like just generating fluxes of stars in specific filters.
|
Just to confirm before I merge - you have run the metal_small example and it runs, right? |
|
yep! |
Added lots of comments to metal_small settings file. This overrides PR #17, in preparation for the deprecation of phat_small (issue #22)