Program Manager Hotfix #1616
Merged
Program Manager Hotfix #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karina-Agliullova
force-pushed
the
program-manager-hotfix
branch
from
8d097a0 to
cb1b75a
Compare
BrianRamsay
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
When editing program managers on multiple programs, users were always assigned to the first edited program. This was caused by inconsistent usage of
.attr()and.data(), which store/retrieve values differently.I also considered writing tests for the function that updates program managers, but it's a very cut-and-dry function, and not even the best tests would've caught this bug.
Also fixed the functionality of the "No managers" text when all program managers are removed from a program.
