-
Notifications
You must be signed in to change notification settings - Fork 15
1558 event blank #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1558 event blank #1581
Conversation
… are not program managers. Note: Create Event option in the sidebar needs to be hidden when the user is a student staff but doesn't have any program to manage
…eds to be turned into meaningful data to serve as a check for the Create Event List in the sidebar
BrianRamsay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes were just merged to development that added an isProgramManager property to the User class, so you can use that now instead of injecting it into the global scope.
… by reusing code that was written earlier in the User model
We were able to fix the issue and use changes @jjijon7000 made. |
|
Took this over and ironed out a few bugs that were left. Ready for review. |
ojmakinde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Program Managers, regardless of whether they are Celts Student Staff or not, can now create events. Other small bugs have been ironed out
…Team/celts into 1558_event_blank
Issue Description
Fixes #1558
Changes
isProgramManagerproperty to check if a CELTS student staff member is also a program manager. If they aren't, it hides the "Create Event" link in the sidebar and also gives a caution on theeventTemplatespage. It looks like this:Testing