Skip to content

Conversation

@mathew2005
Copy link
Member

@mathew2005 mathew2005 commented Jul 15, 2025

Issue Description

Fixes #1558

  • This issue occurs when you make a normal student a student staff member by going to Admin>Settings>Add a Celts student staff member.

Changes

  • used isProgramManager property to check if a CELTS student staff member is also a program manager. If they aren't, it hides the "Create Event" link in the sidebar and also gives a caution on the eventTemplates page. It looks like this:
image

Testing

  • Go to the sidebar and navigate to Admin>Settings, and go to Add a CELTS student staff and add ayisie.
  • Now if you change the user to ayisie, you shouldn't be able to see the "Create Event" list in the sidebar.
  • Afterwards, change back to an admin user.
  • If you go to Admin>Settings and then navigate to the Program Management Accordion, and add ayisie to one or more programs. After you switch back to ayisie you should be able to see the "Create Event" link in the sidebar

… are not program managers. Note: Create Event option in the sidebar needs to be hidden when the user is a student staff but doesn't have any program to manage
…eds to be turned into meaningful data to serve as a check for the Create Event List in the sidebar
Copy link
Contributor

@BrianRamsay BrianRamsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes were just merged to development that added an isProgramManager property to the User class, so you can use that now instead of injecting it into the global scope.

@github-actions
Copy link

View Code Coverage

@mathew2005
Copy link
Member Author

Some changes were just merged to development that added an isProgramManager property to the User class, so you can use that now instead of injecting it into the global scope.

We were able to fix the issue and use changes @jjijon7000 made.

@mathew2005 mathew2005 requested a review from BrianRamsay July 16, 2025 14:51
@ojmakinde ojmakinde self-requested a review September 11, 2025 17:28
@ojmakinde
Copy link
Contributor

Took this over and ironed out a few bugs that were left. Ready for review.

@ojmakinde ojmakinde requested review from ojmakinde and removed request for ojmakinde September 11, 2025 18:05
ojmakinde
ojmakinde previously approved these changes Sep 11, 2025
Copy link
Contributor

@ojmakinde ojmakinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program Managers, regardless of whether they are Celts Student Staff or not, can now create events. Other small bugs have been ironed out

@BrianRamsay BrianRamsay merged commit 8f8066d into development Sep 12, 2025
0 of 4 checks passed
@BrianRamsay BrianRamsay deleted the 1558_event_blank branch September 12, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Event is blank for some student Admins.

5 participants