Skip to content

refactor: 기본 문항 추가 로직 제거(롤백) #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanooGwan merged 1 commit into from
Feb 25, 2026
Merged

refactor: 기본 문항 추가 로직 제거(롤백) #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions src/main/java/gg/agit/konect/domain/club/service/ClubService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,10 @@
import gg.agit.konect.domain.club.dto.ClubsResponse;
import gg.agit.konect.domain.club.dto.MyManagedClubResponse;
import gg.agit.konect.domain.club.model.Club;
import gg.agit.konect.domain.club.model.ClubApplyQuestion;
import gg.agit.konect.domain.club.model.ClubMember;
import gg.agit.konect.domain.club.model.ClubMembers;
import gg.agit.konect.domain.club.model.ClubRecruitment;
import gg.agit.konect.domain.club.model.ClubSummaryInfo;
import gg.agit.konect.domain.club.repository.ClubApplyQuestionRepository;
import gg.agit.konect.domain.club.repository.ClubApplyRepository;
import gg.agit.konect.domain.club.repository.ClubMemberRepository;
import gg.agit.konect.domain.club.repository.ClubQueryRepository;
Expand All @@ -53,7 +51,6 @@ public class ClubService {
private final ClubRepository clubRepository;
private final ClubMemberRepository clubMemberRepository;
private final ClubApplyRepository clubApplyRepository;
private final ClubApplyQuestionRepository clubApplyQuestionRepository;
private final UserRepository userRepository;
private final ClubPermissionValidator clubPermissionValidator;
private final ChatRoomRepository chatRoomRepository;
Expand Down Expand Up @@ -129,25 +126,9 @@ public ClubDetailResponse createClub(Integer userId, ClubCreateRequest request)
ClubMember savedPresident = clubMemberRepository.save(president);
chatRoomMembershipService.addClubMember(savedPresident);

createDefaultApplyQuestions(savedClub);

return getClubDetail(savedClub.getId(), userId);
}

private void createDefaultApplyQuestions(Club club) {
ClubApplyQuestion phoneQuestion = ClubApplyQuestion.of(
club,
"본인의 전화번호를 입력해주세요.",
true
);
ClubApplyQuestion motivationQuestion = ClubApplyQuestion.of(
club,
"지원 동기",
false
);
clubApplyQuestionRepository.saveAll(List.of(phoneQuestion, motivationQuestion));
}

@Transactional
public void updateInfo(Integer clubId, Integer userId, ClubUpdateRequest request) {
userRepository.getById(userId);
Expand Down