Skip to content

fix: Delete 호출 후 flush 수행 #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanooGwan merged 1 commit into from
Feb 23, 2026
+4 −1
Merged

fix: Delete 호출 후 flush 수행 #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/gg/agit/konect/domain/user/repository/UserRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,7 @@ List<User> findUserIdsByUniversityAndStudentYear(

void delete(User user);

void flush();

List<User> findAllByIdIn(List<Integer> ids);
}
3 changes: 2 additions & 1 deletion src/main/java/gg/agit/konect/domain/user/service/UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ private void validateStudentNumberDuplicationOnSignup(Integer universityId, Stri
}
}

@Transactional
@Transactional(readOnly = false)
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Transactional 어노테이션은 기본적으로 readOnly = false입니다. 명시적으로 readOnly = false를 지정하는 것은 불필요합니다. 클래스 레벨에서 @Transactional(readOnly = true)가 선언되어 있어 메서드 레벨에서 오버라이드가 필요하지만, @Transactional만 사용해도 충분합니다.

Suggested change
@Transactional(readOnly = false)
@Transactional

Copilot uses AI. Check for mistakes.
public void deleteUser(Integer userId) {
User user = userRepository.getById(userId);

Expand All @@ -221,6 +221,7 @@ public void deleteUser(Integer userId) {
}

userRepository.delete(user);
userRepository.flush();

applicationEventPublisher.publishEvent(
UserWithdrawnEvent.from(user.getEmail(), user.getProvider().name())
Expand Down