Conversation
ff1451
approved these changes
Feb 2, 2026
Contributor
ff1451
left a comment
There was a problem hiding this comment.
고생하셨습니다 일단 머지해주시면 제가 누락 로깅 추가해야하는거 있어서 그거 추가하면서 Lint 수정할게요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
[공통]
LostItemsHeader제거 후LostItemList으로 통합[웹]
3. 검색창 글씨 제한 100자
4. '장소명'이 길 때 '분실 일자'가 잘리지 않게 수정
5. 검색 시, 1페이지가 사라지는 문제 수정
6. 공지사항과 분실물 템플릿 분리 -> 분실물 클릭시 공지사항으로 가는 문제 수정
[모바일]
7. 제목에 | 없는 문제
8. 신고된 게시글을 hover가 있고 일반 게시글은 없는 문제 수정
9. 스크롤 하면 검색창, 필터 부분이 사라지는 문제 수정
10. 사파리에서 바텀 시트가 안 보이는 문제 수정 -> 기존 dialog로 되어있던 바텀시트를 div로 변경
11. 주소 조작 방지 (ex. https://stage.koreatech.in/lost-item?page=10000)
12. 분실물 페이지 양옆 패딩 8px로 수정 (메인 화면과 동일하게)
ScreenShot 📷
Precaution
Safari 환경은 테스트를 하지 못해서 믿음으로 하였습니다..맥북이신 분들은 10번 테스트 해주시면 감사하겠습니다 !!
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint