Conversation
dooohun
reviewed
Jan 29, 2026
Contributor
dooohun
left a comment
dooohun
left a comment
There was a problem hiding this comment.
수고하셨습니다! 간단하게 리뷰 달았습니다. 답변 부탁드립니다~🙂
| isBottomButtonDisabled={status === 'pending'} | ||
| > | ||
| <LostItemForm type={type} count={0} lostItem={lostItem} lostItemHandler={customLostItemHandler} /> | ||
| <LostItemForm type={type} count={0} totalCount={1} lostItem={lostItem} lostItemHandler={customLostItemHandler} /> |
Contributor
Author
There was a problem hiding this comment.
totalCount는 현재 등록된 분실물/습득물의 총 개수를 의미하며 아이템이 2개 이상일 때만 삭제 버튼을 표시하기 위해 사용됩니다!
| const dayRef = useRef<HTMLDivElement>(null); | ||
|
|
||
| const today = useMemo(() => new Date(), []); | ||
| const [pendingDate, setPendingDate] = useState<Date>(selectedDate); |
Contributor
There was a problem hiding this comment.
요거 왜 pendingDate를 추가로 넣었나요?? 그냥 selectedDate 상태로 처리하면 안되나요? props로 setSelectedDate를 받아서 충분히 처리 가능할 거 같은데, 이유가 궁금합니다.
Contributor
Author
There was a problem hiding this comment.
QA 과정에서 외부 클릭만으로 닫히는 방식이다보니 사용자가 헷갈릴 수 있겠다는 의견이 나와 사진과 같이 확인 버튼이 추가되었습니다.
그래서 확인 버튼을 누르기 전에는 DatePicker 내부에서만 상태를 관리하다가 확인을 누르면 해당 값이 form에 적용되는 흐름을 생각하여 새로운 상태를 추가하게 되었습니다.
dooohun
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
https://docs.google.com/document/d/1nQL__xoQSVLTQsG4tO3qvi2VIFRes_HhHvr_AcjOR84/edit?tab=t.0
https://docs.google.com/document/d/1sRskFjVc6Q3R5nFUxdLbFNSBr4j0i5hndla_k4KHqWs/edit?tab=t.0#heading=h.s9iqanuzsgiw
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint