[캠퍼스] 분실물 상세 페이지 및 최근 분실물 컴포넌트 구현#1131
Merged
ff1451 merged 11 commits intofeat/lost-item-sprintfrom Jan 19, 2026
Merged
Conversation
ff1451
changed the title
ff1451
changed the base branch from
feat/#1128/lost-item-ui
to
feat/lost-item-sprint
ff1451
changed the base branch from
feat/lost-item-sprint
to
feat/#1128/lost-item-ui
dooohun
approved these changes
Jan 19, 2026
Comment on lines
+19
to
+30
| <Head> | ||
| <title>{title}</title> | ||
| <meta name="description" content={description} /> | ||
| <meta property="og:title" content={title} /> | ||
| <meta property="og:description" content={description} /> | ||
| <meta property="og:image" content={image} /> | ||
| <meta property="og:type" content="article" /> | ||
| <meta name="twitter:card" content="summary_large_image" /> | ||
| <meta name="twitter:title" content={title} /> | ||
| <meta name="twitter:description" content={description} /> | ||
| <meta name="twitter:image" content={image} /> | ||
| </Head> |
Contributor
There was a problem hiding this comment.
좋습니다👍 필요한 메타 데이터들을 잘 넣은 거 같아요!
| options: UseInfiniteScrollOptions = {}, | ||
| ) => { | ||
| const { threshold = 0.3, enabled = true } = options; | ||
| const observerRef = useRef<HTMLDivElement>(null); |
Contributor
There was a problem hiding this comment.
Suggested change
| const observerRef = useRef<HTMLDivElement>(null); | |
| const observerRef = useRef<HTMLElement>(null); |
좀 더 상위 타입을 사용하는 게 좋을 거 같아요.
Comment on lines
88
to
95
| if (token) { | ||
| onSuccess(); | ||
| } else { | ||
| portalManager.open((portalOption) => ( | ||
| <LoginRequiredModal title={modalTitle} description="로그인 후 이용해주세요." onClose={portalOption.close} /> | ||
| )); | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (token) { | |
| onSuccess(); | |
| } else { | |
| portalManager.open((portalOption) => ( | |
| <LoginRequiredModal title={modalTitle} description="로그인 후 이용해주세요." onClose={portalOption.close} /> | |
| )); | |
| } | |
| }; | |
| if (token) { | |
| onSuccess(); | |
| return; | |
| } | |
| portalManager.open((portalOption) => ( | |
| <LoginRequiredModal title={modalTitle} description="로그인 후 이용해주세요." onClose={portalOption.close} /> | |
| )); | |
| } | |
| }; |
사소하지만 else 대신 return하는게 좋을 거 같습니다.
Contributor
Author
There was a problem hiding this comment.
아래 내용과 함께 수정했습니다!
Comment on lines
109
to
114
| if (isMobile) { | ||
| navigate(ROUTES.ArticlesReport({ id: String(articleId), isLink: true })); | ||
| } else { | ||
| openReportModal(); | ||
| } | ||
| }); |
ff1451
changed the base branch from
feat/#1128/lost-item-ui
to
feat/lost-item-sprint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
Precaution
작업 완료하고 보니 PR이 너무 커져서 3개로 나누어 올리게 되었습니다. 미리 나누지 못한 점 죄송합니다...
Related PRs
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint