Merged
Conversation
dh2906
approved these changes
Jan 19, 2026
Comment on lines
+195
to
+196
| lostItemArticle.deleteImages(request.deleteImageIds()); | ||
| lostItemArticle.addNewImages(request.newImages()); |
Contributor
There was a problem hiding this comment.
삭제 없이 새 이미지를 매 요청마다 최대 10개씩 추가할 수 있어, 동일한 요청을 여러 번 보낼 경우 총 이미지 수가 10개를 초과할 위험이 있어 보여요!
Collaborator
Author
There was a problem hiding this comment.
이거 게시글 등록 API에서도 검증 로직이 없어서 뺐습니다.
kih1015
approved these changes
Jan 19, 2026
Comment on lines
+183
to
+199
| @Transactional | ||
| public LostItemArticleResponse updateLostItemArticle(Integer userId, Integer articleId, LostItemArticleUpdateRequest request) { | ||
| LostItemArticle lostItemArticle = lostItemArticleRepository.getByArticleId(articleId); | ||
| lostItemArticle.checkOwnership(userId); | ||
|
|
||
| lostItemArticle.update( | ||
| request.category(), | ||
| request.foundPlace(), | ||
| request.foundDate(), | ||
| request.content() | ||
| ); | ||
|
|
||
| lostItemArticle.deleteImages(request.deleteImageIds()); | ||
| lostItemArticle.addNewImages(request.newImages()); | ||
|
|
||
| return LostItemArticleResponse.of(lostItemArticle.getArticle(), true); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
💬 참고 사항
✅ Checklist (완료 조건)