Merged
Conversation
DHkimgit
requested review from
BaeJinho4028,
ImTotem,
Soundbar91,
dh2906 and
taejinn
dh2906
approved these changes
Jan 15, 2026
Comment on lines
37
to
39
| return Optional.ofNullable(lostItemArticle.getAuthor()) | ||
| .map(User::getProfileImageUrl) | ||
| .orElseThrow(() -> CustomException.of(ApiResponseCode.NOT_FOUND_CHAT_PARTNER)); |
Contributor
There was a problem hiding this comment.
유저의 profileImageUrl이 null인 경우는 404가 터지는 로직 같은데, 현재 거의 모든 유저는 이미지가 없어서 거의 무조건 터지지 않나요?? 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
{ "message": "분실물 게시글 채팅방이 존재하지 않습니다.", "errorTraceId": "123e4567-e89b-12d3-a456-426614174000", "code": "NOT_FOUND_CHAT_PARTNER" }💬 참고 사항
✅ Checklist (완료 조건)