Conversation
DHkimgit
requested review from
BaeJinho4028,
ImTotem,
Soundbar91,
asa9874 and
taejinn
Soundbar91
reviewed
Dec 24, 2025
Collaborator
There was a problem hiding this comment.
코드 확인하고 궁금증이 생겨서 코멘트 남깁니다 !
GET /course/registration/search -> GET /v3/lectures , GET /course/registration/precourse -> GET /v3/timetable/lectrues?frame_id로 대체할 수 있을 거 같은데 어떻게 생각하시나요 ??
금 A1 와 같은 데이터는 수강신청 연습이라는 기능에서 크게 중요하지 않는 데이터라 생각되고, 클라에서 정적으로 아무 값이나 내려도 무관하다고 생각했습니다. 기타 다른 데이터들도 동일하게 정적으로 내려도 괜찮을 거 같아요
BaeJinho4028
approved these changes
Jan 9, 2026
| } | ||
|
|
||
| private BooleanExpression nameContains(String name) { | ||
| return name != null ? lecture.name.containsIgnoreCase(name) : null; |
Collaborator
There was a problem hiding this comment.
강의 늘어날수록 느려지지않을까 걱정이 되긴하네요
Soundbar91
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
💬 참고 사항
✅ Checklist (완료 조건)