-
Notifications
You must be signed in to change notification settings - Fork 2
fix: 버전 매핑 에러 수정 #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: 버전 매핑 에러 수정 #191
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
984f128
fix: 버그 수정
songsunkook 0769e32
refactor: 예외 수정
songsunkook 3bffb58
test: 테스트 분리
songsunkook 880731b
feat: 버전 최신화 메서드 작성
songsunkook 81fffd7
Merge branch 'develop' into feature/186-fix-version
songsunkook b2411d8
refactor: 응답 간결화 및 버그 수정
songsunkook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 0 additions & 18 deletions
18
src/main/java/in/koreatech/koin/domain/version/exception/VersionException.java
This file was deleted.
Oops, something went wrong.
17 changes: 17 additions & 0 deletions
17
src/main/java/in/koreatech/koin/domain/version/exception/VersionTypeNotFoundException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package in.koreatech.koin.domain.version.exception; | ||
|
|
||
| import in.koreatech.koin.global.exception.DataNotFoundException; | ||
|
|
||
| public class VersionTypeNotFoundException extends DataNotFoundException { | ||
|
|
||
| public static final String DEFAULT_MESSAGE = "존재하지 않는 버전 타입입니다."; | ||
|
|
||
| public VersionTypeNotFoundException(String message) { | ||
| super(message); | ||
| } | ||
|
|
||
| public static VersionTypeNotFoundException withDetail(String detail) { | ||
| String message = String.format("%s %s", DEFAULT_MESSAGE, detail); | ||
| return new VersionTypeNotFoundException(message); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/main/java/in/koreatech/koin/global/config/ClockConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package in.koreatech.koin.global.config; | ||
|
|
||
| import java.time.Clock; | ||
|
|
||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration | ||
| public class ClockConfig { | ||
|
|
||
| @Bean | ||
| public Clock clock() { | ||
| return Clock.systemDefaultZone(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R
이렇게 구성했을 때 enum이 필요없는 구조가 되지 않나요?
필요없다면 enum 없애는게 나아보이는데 어떻게 생각하나요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API 파라미터와 DB 컬럼명의 일치 여부 검증 로직을 강화하는 역할로 쓰일 수 있기 때문에 남겨두는게 적절하다고 생각합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음~ 알겠습니다~!