Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ticklabels to labels #365

Merged
merged 2 commits into from
Jun 14, 2024
Merged

change ticklabels to labels #365

merged 2 commits into from
Jun 14, 2024

Conversation

jckkvs
Copy link
Contributor

@jckkvs jckkvs commented May 22, 2024

This pull request addresses a minor inconsistency in the set_ticklabels method call within the y_axis configuration. Specifically, it updates the method call from y_axis.set_ticklabels(ticklabels=names) to y_axis.set_ticklabels(labels=names).

https://matplotlib.org/stable/api/_as_gen/matplotlib.axes.Axes.set_xticklabels.html

@j-ittner
Copy link
Member

j-ittner commented Jun 9, 2024

@jckkvs thanks for spotting this! It appears the name of arg ticklabels was changed to labels in matplotlib 3.7.

How about we ditch the arg name altogether, and pass the names as a positional argument, i.e. y_axis.set_ticklabels(names)? Actually we could do the same with the preceding set_ticks.

@jckkvs
Copy link
Contributor Author

jckkvs commented Jun 12, 2024

@j-ittner
I have incorporated your suggestion.

Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for spotting and fixing this!!

@j-ittner j-ittner merged commit 8649aae into BCG-X-Official:2.1.x Jun 14, 2024
7 checks passed
@j-ittner j-ittner self-assigned this Jun 14, 2024
@j-ittner j-ittner added the bug Something isn't working label Jun 14, 2024
@j-ittner j-ittner added this to the 2.1.3 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants