Initial ophyd-async support - #1188
Open
canismarko wants to merge 5 commits into
Open
Conversation
Async support is an optional dependency to not break backwards compatability. Ophyd-async requies python>=3.11 but apstools can make do with python>=3.10.
We might want change this without notice ophyd-async devices without notice, so renaming the package makes it clear that this is not meant to be stable.
Contributor
|
Py 3.10 is close to end of support. It's safe for you to drop it from the test matrix here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haven contains a number of ophyd-async devices that could be useful for other beamlines. I am hoping to start moving some of these into apstools since ophyd-async is getting close to its first stable release. Ophyd-async is especially good for fly-scanning detectors, which seems useful to others.
This PR:
I put the ophyd-async devices in a new
_devices_asyncpackage so existing deployments shouldn't be affected. I also addedophyd-asyncas an optional dependency (pip install apstools[async]). My thought was that once ophyd-async is stable, we can rename this package todevices_asyncand make ophyd-async a default dependency to indicate that this support is ready for general use.The current release of ophyd-async depends on python >= 3.11. How important is maintaining python 3.10 support? It is schedule to go end-of-life in October.