WIP: Feature/Add_typehints and guarnieri stubs #1063
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prjemian
reviewed
Mar 27, 2025
prjemian
reviewed
Mar 27, 2025
prjemian
reviewed
Mar 27, 2025
Closed
|
With #1067 resolved, merge |
|
Maybe you realized this already, but guarneri already has types. Shouldn't need stubs. |
…VS-Filters). Added generalized support for HHL apertures/slits.
ravescovi
force-pushed
the
feature/typehints
branch
from
10e286d to
0d976f0
Compare
2025-04-25T16:56:29.1964943Z E ImportError: cannot import name 'JJtransfocator1x' from 'apstools.devices.jj_transfocators' (/home/runner/work/apstools/apstools/apstools/devices/jj_transfocators.py)Need to merge main branch into this one to get the |
|
Leave this PR here while I break this into smaller branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.