Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rest login error 500 for starkiller #120

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Conversation

justsly
Copy link

@justsly justsly commented Mar 9, 2020

try to login via the rest api always got me the following error:

HTTP/1.0 500
Content-Type: application/json
Content-Length: 54
Access-Control-Allow-Origin: *
Server: Werkzeug/1.0.0 Python/3.6.9
Date: Mon, 09 Mar 2020 15:48:02 GMT

{"error":"OperationalError('no such column: true',)"}


enabled must be check for '1' not 'true' to fix this issue and allow starkiller to work with the latest version of empire.

try to login via the rest api always got me the following error:

HTTP/1.0 500
Content-Type: application/json
Content-Length: 54
Access-Control-Allow-Origin: *
Server: Werkzeug/1.0.0 Python/3.6.9
Date: Mon, 09 Mar 2020 15:48:02 GMT

{"error":"OperationalError('no such column: true',)"}

---------------------------------------------------------

enabled must be check for '1' not 'true' to fix this issue and allow starkiller to work with the latest version of empire.
@vinnybod
Copy link

vinnybod commented Mar 9, 2020

@justsly what version of Sqlite are you running? I think this might come down to whether your version of SQLite supports using boolean literals in queries, which came in SQLite 3.23

@Cx01N FWIW I think this is the only place that Empire uses this feature, so we can merge it to a 3.1.2

@justsly
Copy link
Author

justsly commented Mar 10, 2020

ah good point. I am running SQLite 3.22 which comes with ubuntu 18.04.4 LTS

@Cx01N Cx01N added the bug Something isn't working label Mar 11, 2020
@Cx01N Cx01N changed the base branch from master to dev March 13, 2020 00:49
@Cx01N Cx01N merged commit 79e7de5 into BC-SECURITY:dev Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants