Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp package depreciated #108

Closed
ShellCode33 opened this issue Feb 24, 2020 · 0 comments · Fixed by #144
Closed

imp package depreciated #108

ShellCode33 opened this issue Feb 24, 2020 · 0 comments · Fixed by #144
Labels
good first issue Good for newcomers python3

Comments

@ShellCode33
Copy link

Hey, thanks for keeping up to date that great tool 👍
According to https://docs.python.org/3/library/imp.html, the imp package (used to preload Empire's modules at runtime) is depreciated since Python 3.4. It would be great to use importlib instead. It seems the import_module function is also available in Python 2 (https://docs.python.org/2/library/importlib.html) so it shouldn't break compatibility !

Empire Version : 3.0.7
@Cx01N Cx01N added the python3 label Feb 26, 2020
@vinnybod vinnybod added the good first issue Good for newcomers label Mar 8, 2020
@Cx01N Cx01N changed the title imp package decreciated imp package depreciated Mar 15, 2020
Cx01N added a commit that referenced this issue Mar 28, 2020
@Cx01N
Replaced imp package with importlib - #108
0ed7951
@Cx01N Cx01N linked a pull request Mar 28, 2020 that will close this issue
V3.1.4 - Bug Fixes #144
Merged
Hubbl3 pushed a commit that referenced this issue Apr 2, 2020
@Cx01N
V3.1.4 - Bug Fixes (#144)
e5f15cb 
* updated version to 3.1.3

* Updated readme

* Updated changelog

* Removed pycrypto references in requirements.txt - #139

* Replaced imp package with importlib - #108

* Removed uselistener print statement

* Undo pycrypto to pycryptodome, conflict with install - #139

* Updated changelog and version
@Cx01N Cx01N closed this as completed Apr 6, 2020
vinnybod added a commit that referenced this issue Jul 27, 2021
@vinnybod
Update README.md (#108)
5271c9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers python3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V3.1.4 - Bug Fixes BC-SECURITY/Empire
3 participants
@ShellCode33 @vinnybod @Cx01N