Quality standards

[vhirtham]

Changes

Describe changes in this PR

Related Issues

Closes # (add issue numbers)

Checks

• updated CHANGELOG.md
• updated tests
• updated doc/
• update example/tutorial notebooks
• review implementation of QualityStandard class in light of the new documentation (Keyword: DirectoryResourceMapping) will be refactored in 0.5.0

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[pep8speaks]

Hello @vhirtham! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-12 12:31:38 UTC

[vhirtham]

The tutorial text is still "work in progress", but the relevant code sections are there and are fully functional.

[vhirtham]

I didn't strip the tutorial from all outputs so that it can be inspected on GitHub. The documentation builds are currently failing for multiple reasons and they have to be fixed first. If this is done, I will remove the outputs from the notebook.

[vhirtham]

Almost forgot: We need to make the cookie-cutter repo public. Otherwise the links wont work

[marscher]

The tutorials needs to be pep8/black formatted.

[marscher]

@vhirtham Is it intended, that a QS directory only have to contain manifests with the same base name and only differing versions? I tried to add another manifest for testing purposes, e.g. test_standard2-1.0.0.yaml and then I get a ValueError("Inconsistent naming of manifest files") raised in config.py:56.

[vhirtham]

@vhirtham Is it intended, that a QS directory only have to contain manifests with the same base name and only differing versions? I tried to add another manifest for testing purposes, e.g. test_standard2-1.0.0.yaml and then I get a ValueError("Inconsistent naming of manifest files") raised in config.py:56.

Yes, it is. It's also mentioned somewhere in the tutorial ;)

[marscher]

There is one mistake in the tag name of the test-standard. It should be "measurement_equipment" now, not "generic_equipment".

The problem we are seeing is due to the fact, that the load_schema function in asdf is lru_cached, so a second call to with the same url (e.g. enable a standard involves a tag url) is resolved to the cache. The local config context circumvents this problem, but I have not yet figured, if it will also hurt performance (due to the lack of caching effects).

[vhirtham]

@marscher Seems like the quality standards somehow carry over to other files now. Are you still on it?

[CagtayFabry]

🚀