Skip to content

54 s390 add s390s390x parser #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

54 s390 add s390s390x parser #56

merged 3 commits into from
Apr 14, 2025

Conversation

sijung07
Copy link
Contributor

@sijung07 sijung07 commented Apr 1, 2025

Closes #54

@sijung07 sijung07 linked an issue Apr 1, 2025 that may be closed by this pull request
@gnrkr789 gnrkr789 force-pushed the 54-s390-add-s390s390x-parser branch from a2adbaf to 07b5667 Compare April 8, 2025 03:10
@gnrkr789 gnrkr789 marked this pull request as ready for review April 8, 2025 03:46
@gnrkr789 gnrkr789 requested a review from a team as a code owner April 8, 2025 03:46
@gnrkr789 gnrkr789 added tier-FrontEnd This is related to the front-end area-Parsing labels Apr 8, 2025
@gnrkr789 gnrkr789 added this to the v0.9.0 milestone Apr 8, 2025
Copy link
Member

@sangkilc sangkilc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except the use of __. Read the CONTRIBUTING.md again and fix them accordingly.

let reader = BinReader.Init isa.Endian

interface IInstructionParsable with
member _.Parse (span: ByteSpan, addr: Addr) =
Terminator.futureFeature (): Instruction
member __.Parse (span: ByteSpan, addr: Addr) =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__ -> _

Same for Line 46

@gnrkr789 gnrkr789 force-pushed the 54-s390-add-s390s390x-parser branch from 07b5667 to bb71a2a Compare April 14, 2025 00:36
@sangkilc sangkilc merged commit ddb4e87 into main Apr 14, 2025
7 checks passed
@sangkilc sangkilc deleted the 54-s390-add-s390s390x-parser branch April 14, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Parsing tier-FrontEnd This is related to the front-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[S390] Add S390/S390x parser
4 participants